Choices.jsのエラーを解消した #4494
Merged
Choices.jsのエラーを解消した #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
コンソールにエラーが表示されてしまうため
|
@saeyama さん |
saeyama
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
@garammasala29 さん、お疲れ様です…！
レビュー対応時に、気づけず申し訳ありません💦 💦 💦
コンソール上でエラーが出ないことを確認出来たのでApproveしました！
よろしくお願いします🙇♀️
|
@saeyama さん |
|
@komagata さん |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
概要
Choices.jsを導入した際(#4385)に出現してしまったコンソールのエラーを解消しました。
セレクトボックスのidの有無で
new Choicesをする形にいたしました。allowHTMLオプションを設定するよう警告も出ていたため追加しています。変更確認方法
bug/resolve-choices.js-errorsをローカルに取り込むbin/setupとrails db:seedを実行しDBの内容を開発環境に反映するrails sでローカル環境を立ち上げ、デベロッパーツールを開いていただくと変更点が確認できます変更前
変更後